Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disable pinch zoom from cli #239

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Nov 15, 2024

Enable touch support and allow disable pinch zoom from command line flag

@Legend-Master Legend-Master mentioned this pull request Nov 15, 2024
17 tasks
@Legend-Master Legend-Master marked this pull request as ready for review November 15, 2024 10:40
@wusyong
Copy link
Member

wusyong commented Nov 18, 2024

What's the motivation to disable pinch zoom as a configuration?

@Legend-Master
Copy link
Contributor Author

This allows you to use your own pinch zoom handlings, for example https://figma.com and https://squoosh.app, I don't think we have preventDefault on touch events implemented currently, so this is a work around for now, also some people just want to make their web app (webview app) feel like a native app with all those web features disabled (personally I'm not a fan of it but there're people want that)

@wusyong
Copy link
Member

wusyong commented Nov 18, 2024

It should implement preventDefault on touch events to Servo directly. I think we could explore other CLI options that could be more crucial.

@Legend-Master
Copy link
Contributor Author

Sure we can, but I still want to argue that attaching non passive touch event listeners hurt performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants