Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support richtext in editor #3

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

support richtext in editor #3

wants to merge 7 commits into from

Conversation

queden
Copy link
Contributor

@queden queden commented Jan 22, 2022

@vercel
Copy link

vercel bot commented Jan 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/verses-xyz/pluriverse/6DX5LQLgYfdaNFYFgTZ1ZDQhoVuK
✅ Preview: https://pluriverse-git-q-editor-verses-xyz.vercel.app

Copy link
Contributor

@spencerc99 spencerc99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work!! left some comments

browser/src/components/core/AutoGrowInput.tsx Outdated Show resolved Hide resolved
browser/src/components/core/AutoGrowInput.tsx Show resolved Hide resolved
onChange={onChange}
placeholder={extraProps.placeholder ? extraProps.placeholder : null}
/>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh also i added a maxLength on the text area in a recent change (you'll need to merge/rebase with main) and that would be good to incorporate here (900 characters)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice! just updated to support this using tiptap's character count

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

browser/src/components/core/AutoGrowInput.tsx Outdated Show resolved Hide resolved
browser/src/components/core/Editor.tsx Outdated Show resolved Hide resolved
browser/src/components/core/Editor.tsx Outdated Show resolved Hide resolved
browser/package.json Outdated Show resolved Hide resolved
browser/src/components/core/AutoGrowInput.tsx Outdated Show resolved Hide resolved
browser/package.json Outdated Show resolved Hide resolved
browser/src/components/core/Editor.tsx Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Jan 29, 2022

@queden is attempting to deploy a commit to the verses Team on Vercel.

To accomplish this, @queden needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

onChange={onChange}
placeholder={extraProps.placeholder ? extraProps.placeholder : null}
/>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

browser/src/components/ContributionCard.tsx Outdated Show resolved Hide resolved
className={`pageProgress ${
page === p ? "selectedPageProgress" : ""
}`}
className={`pageProgress ${page === p ? "selectedPageProgress" : ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you revert this change

Copy link
Contributor Author

@queden queden Feb 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol not on my usual dev setup this week and some random vs code package did this my bad, in what world does this look good

browser/src/components/core/AutoGrowInput.tsx Show resolved Hide resolved
browser/src/components/core/Editor.css Outdated Show resolved Hide resolved
browser/src/components/core/commands.ts Show resolved Hide resolved
browser/src/helpers/api.ts Outdated Show resolved Hide resolved
browser/src/helpers/api.ts Outdated Show resolved Hide resolved
browser/src/types/common/server-api/index.ts Outdated Show resolved Hide resolved
"@tiptap/extension-paragraph": "^2.0.0-beta.23",
"@tiptap/extension-placeholder": "^2.0.0-beta.46",
"@tiptap/extension-text": "^2.0.0-beta.15",
"@tiptap/extension-underline": "^2.0.0-beta.22",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you remove this / would do a pass and remove anything we don't need

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed!

@@ -147,45 +169,48 @@ export function ContributionCard({
<p className="author text-color-purple-200">{authorDisplay}</p>
<p>{dateDisplay}</p>
</p>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay i need to remove whatever prettify package is on this editor sorry lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants