Updated LinuxCNC 2.8 Support #13
Conversation
| @@ -46,10 +46,11 @@ O400 endif | |||
| F #<_hal[probe.ps_searchvel]> | |||
| G91 | |||
| G38.2 Z #<_ini[TOOLSENSOR]MAXPROBE> | |||
| G0 Z0.26 | |||
| G38.4 Z2 | |||
| G0 Z0.5 | |||
There was a problem hiding this comment.
This isn't strictly a 2.8 change - I found just lifting 0.26 up wasn't always enough, so instead I updated this to probe in the opposite direction, then go a little bit more again.
| @@ -58,7 +59,6 @@ O500 endif | |||
|
|
|||
| G90 | |||
| G53 G0 Z[#<_ini[CHANGE_POSITION]Z>] | |||
| G53 G0 X[#<_ini[CHANGE_POSITION]X>] Y[#<_ini[CHANGE_POSITION]Y>] | |||
There was a problem hiding this comment.
Again, this wasn't strictly a 2.8 change - however there was no reason to return to the X/Y change position after a tool change that I could see.
| unlinkp iocontrol.0.tool-change | ||
| unlinkp iocontrol.0.tool-changed | ||
| #unlinkp iocontrol.0.tool-change | ||
| #unlinkp iocontrol.0.tool-changed |
There was a problem hiding this comment.
If users copy this file as is / as per the readme, we end up unlinking the connections made in probe_screen.hal. I haven't checked, but I suspect the ordering of when different things are loaded has changed in 2.8.
| else: # continuous jogging | ||
| self.command.jog( linuxcnc.JOG_CONTINUOUS, axisnumber, direction * velocity ) | ||
| self.command.jog( linuxcnc.JOG_CONTINUOUS, False, axisnumber, direction * velocity ) |
There was a problem hiding this comment.
The other 2.8 PR open has self.command.teleop_enable(0) and True where I've used false. With a dual motor / gantry axis, using teleop=0/False results in putting linuxCNC back into joint mode which can cause only a single motor of the pair to run.
| self.command.mode( linuxcnc.MODE_MDI ) | ||
| self.command.wait_complete() | ||
| self.command.mdi( "G10 L2 P0 Z%s" % origin ) | ||
| self.command.mdi( "G10 L2 P0 Z%s" % blockheight ) |
There was a problem hiding this comment.
Again, not strictly a 2.8 change. However, without this change - enabling and using M6 remap would always result in the Z offset being off by the Z Axis's MIN_LIMIT.
| def clicked_btn_probe_tool_setter(self, data = None): | ||
|
|
||
| @restore_mode | ||
| def clicked_btn_probe_tool_setter(self, gtkbuttondata = None): |
There was a problem hiding this comment.
i believe this is a typo @kiall, should be: def clicked_btn_probe_tool_setter(self, gtkbutton, data = None):
There was a problem hiding this comment.
Fixed in https://github.com/linuxcnc-probe-screen/probe-screen - a hopefully community maintained fork :)
There was a problem hiding this comment.
awesome! thank you for the fixes and the fork! by the way, i tested all these changes and it seems to be working now
Now that 2.8 is released and stable, it's likely more & more people will upgrade and want 2.8 support.
This PR updates everything I could find + validate to support LinuxCNC 2.8.
Ideally, you would create a "linuxcnc-2.7" or similar branch off the current master for people who want the 2.7 version!
Thanks!