Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run test-asan-undefined in CI Linux GCC and upgrade abseil-cpp to 20240722.0 LTS #1457

Merged
merged 4 commits into from
Oct 6, 2024
Merged

Do not run test-asan-undefined in CI Linux GCC and upgrade abseil-cpp to 20240722.0 LTS #1457

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf6c5c4
Update abseil-cpp.wrap to 20240722.0-1
garrettboone Oct 1, 2024
0c96a32
Use active source url for abseil release 20240722.0
garrettboone Oct 1, 2024
7ee6165
CI: do not run test-asan-undefined in Linux GCC
ibc Oct 3, 2024
ce94ea1
let's try
ibc Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 35 additions & 6 deletions .github/workflows/mediasoup-worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,35 +21,67 @@ jobs:
# Workaround for this issue in Ubunt 20.04:
# https://github.com/versatica/mediasoup/actions/runs/9992113733/job/27616379442?pr=1427
workaround-ubuntu-20-04: true
run-test-asan-address: true
# Skip test-asan-undefined in Linux with GCC due to a bug in GCC
# that affects abseil-cpp:
# https://github.com/abseil/abseil-cpp/issues/1634
run-test-asan-undefined: false
run-test-asan-thread: true
- os: ubuntu-20.04
cc: clang
cxx: clang++
workaround-ubuntu-20-04: true
run-test-asan-address: true
run-test-asan-undefined: true
run-test-asan-thread: true
- os: ubuntu-22.04
cc: gcc
cxx: g++
run-test-asan-address: true
run-test-asan-undefined: false
run-test-asan-thread: true
- os: ubuntu-22.04
cc: clang
cxx: clang++
run-test-asan-address: true
run-test-asan-undefined: true
run-test-asan-thread: true
- os: ubuntu-24.04
cc: gcc
cxx: g++
pip-break-system-packages: true
run-test-asan-address: true
run-test-asan-undefined: false
run-test-asan-thread: true
- os: ubuntu-24.04
cc: clang
cxx: clang++
pip-break-system-packages: true
run-test-asan-address: true
run-test-asan-undefined: true
run-test-asan-thread: true
- os: macos-12
cc: gcc
cxx: g++
pip-break-system-packages: true
# Address Sanitizer does not work on MacOS.
run-test-asan-address: false
run-test-asan-undefined: false
run-test-asan-thread: false
- os: macos-14
cc: clang
cxx: clang++
run-test-asan-address: false
run-test-asan-undefined: false
run-test-asan-thread: false
pip-break-system-packages: true
- os: windows-2022
cc: cl
cxx: cl
# Address Sanitizer does not work on Windows.
run-test-asan-address: false
run-test-asan-undefined: false
run-test-asan-thread: false
# A single Node.js version should be fine for C++.
node:
- 22
Expand Down Expand Up @@ -118,20 +150,17 @@ jobs:
name: invoke -r worker test
run: invoke -r worker test

# Address Sanitizer only works on Linux.
# Let's clean everything before rebuilding worker tests with ASAN.
- if: runner.os == 'Linux'
- if: ${{ matrix.build.run-test-asan-address }}
name: invoke -r worker test-asan-address
run: invoke -r worker clean-all && invoke -r worker test-asan-address

# Address Sanitizer only works on Linux.
# Let's clean everything before rebuilding worker tests with ASAN.
- if: runner.os == 'Linux'
- if: ${{ matrix.build.run-test-asan-undefined }}
name: invoke -r worker test-asan-undefined
run: invoke -r worker clean-all && invoke -r worker test-asan-undefined

# Address Sanitizer only works on Linux.
# Let's clean everything before rebuilding worker tests with ASAN.
- if: runner.os == 'Linux'
- if: ${{ matrix.build.run-test-asan-thread }}
name: invoke -r worker test-asan-thread
run: invoke -r worker clean-all && invoke -r worker test-asan-thread
18 changes: 9 additions & 9 deletions worker/subprojects/abseil-cpp.wrap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
[wrap-file]
directory = abseil-cpp-20230802.1
source_url = https://github.com/abseil/abseil-cpp/archive/20230802.1.tar.gz
source_filename = abseil-cpp-20230802.1.tar.gz
source_hash = 987ce98f02eefbaf930d6e38ab16aa05737234d7afbab2d5c4ea7adbe50c28ed
patch_filename = abseil-cpp_20230802.1-2_patch.zip
patch_url = https://wrapdb.mesonbuild.com/v2/abseil-cpp_20230802.1-2/get_patch
patch_hash = f6ceb55ca4b0995d826cbdefc0a37e0f8b6202d3e7ecb3436298f54d3a23942b
source_fallback_url = https://github.com/mesonbuild/wrapdb/releases/download/abseil-cpp_20230802.1-2/abseil-cpp-20230802.1.tar.gz
wrapdb_version = 20230802.1-2
directory = abseil-cpp-20240722.0
source_url = https://github.com/abseil/abseil-cpp/releases/download/20240722.0/abseil-cpp-20240722.0.tar.gz
source_filename = abseil-cpp-20240722.0.tar.gz
source_hash = f50e5ac311a81382da7fa75b97310e4b9006474f9560ac46f54a9967f07d4ae3
patch_filename = abseil-cpp_20240722.0-1_patch.zip
patch_url = https://wrapdb.mesonbuild.com/v2/abseil-cpp_20240722.0-1/get_patch
patch_hash = 692bbbc39cacaba4dc4b0c8b2fbbe32736c9cde6377acfa0d52088797af14ded
source_fallback_url = https://github.com/mesonbuild/wrapdb/releases/download/abseil-cpp_20240722.0-1/abseil-cpp-20240722.0.tar.gz
wrapdb_version = 20240722.0-1

[provide]
absl_base = absl_base_dep
Expand Down
Loading