Add a test to check issue #1366 and use Debug mode #1368
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporal PR just to test #1366 in different machines.
CC @jmillan @shaymagsumov
Results using
absl::btree_set
Here we can see that, when compiled in debug mode,
mediasoup-worker
CI fail in all OS and archs and compilers (in all but Windows) due to the transitivity violation, i.e.comp(a,b) && comp(b,c) -> comp(a,c)
.All CI fail: https://github.com/versatica/mediasoup/actions/runs/8612477995/
Results using
std::set
Despite C++ containers are supposed to also require transitivity (https://en.cppreference.com/w/cpp/container/set, https://en.cppreference.com/w/cpp/named_req/Compare), the same transitivity violation doesn't affect standard C++ STD containers when compiled in debug mode. Why? No idea, but it doesn't fail in any OS/arch/compiler.
All CI passes: https://github.com/versatica/mediasoup/actions/runs/8612301409/
Conclusion