Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlainTransportOptions: add optional rtcpListenInfo #1099

Merged

Conversation

ibc
Copy link
Member

@ibc ibc commented Jun 1, 2023

Fixes #1096

NOTE: PR targeting flatbuffers branch since it depends on the new TransportListenInfo type.

@ibc ibc requested review from jmillan and nazar-pc June 1, 2023 16:40
@ibc ibc linked an issue Jun 1, 2023 that may be closed by this pull request
@ibc ibc mentioned this pull request Jun 1, 2023
7 tasks
Copy link
Member

@jmillan jmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little change requested. Other than that 👍

node/src/Router.ts Outdated Show resolved Hide resolved
Co-authored-by: José Luis Millán <[email protected]>
@ibc ibc merged commit 6594f07 into flatbuffers Jun 2, 2023
@ibc ibc deleted the flatbuffers-add-rtcplisteninfo-in-router-createplaintransport branch June 2, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Plain Transport Custom RTCP Port
2 participants