Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VersionPrefix support to csproj, vbproj, fsproj, and props files #8

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Add VersionPrefix support to csproj, vbproj, fsproj, and props files #8

merged 6 commits into from
Feb 29, 2024

Conversation

Invvard
Copy link
Contributor

@Invvard Invvard commented Feb 28, 2024

In *.csproj and *.props files, by default, Version is composed of VersionPrefix and VersionSuffix, and only VersionPrefix, if VersionSuffix is blank.

Andrew Lock explain this very well in this blog post : Version vs VersionSuffix vs PackageVersion: What do they all mean?

I only added support for VersionPrefix for those file type because I know they exist and are used, not so sure for other supported files.

Tests for those 2 file types are updated.

I did not find any contribution directives, so I went for the obvious edits but if something is missing, I'll be happy to comply :)

@vers-one
Copy link
Owner

Thank you for your contribution!

The change looks great. One more thing I would add to this pull request before merging it is an update to the README.md file. There is Additional notes section that lists all the supported tags. Since we're adding one more tag, we need to mention it there as well.

…or VersionPrefix in .csproj, .vbproj, .fsproj and .props files and Version in .nuspec files to accurately detect version declarations in the project
@Invvard
Copy link
Contributor Author

Invvard commented Feb 29, 2024

Hi,
Always a pleasure to contribute!

I added the VersionPrefix to fsproj and vbproj as well.
Additional notes have been updated and I took the liberty to split nuspec files from other types as it only look for the Version tag. I hope I did not overstep but if you prefer I rollback this change just say the word :)

README.md Outdated Show resolved Hide resolved
@vers-one vers-one changed the title Add VersionPrefix support to csproj and props files Add VersionPrefix support to csproj, vbproj, fsproj, and props files Feb 29, 2024
@vers-one vers-one merged commit e4364cf into vers-one:main Feb 29, 2024
2 checks passed
@vers-one
Copy link
Owner

Thank you!

Released in version 1.5.

@Invvard Invvard deleted the feature/add-versionprefix-csproj-props branch March 5, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants