General code cleanup part #1 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move usage of coverage to run_tests
* spylon can already do this * It was broken looking for the python cell magic * It uses a metakernel.IPythonKernel instead of the active IPython kernel
* Show a reasonable error message when input is incomplete according to the interpreter * Only use one executors in the thread pool: we must do one thing at a time anyway
Going to do this separately after the general cleanup This reverts commit c8fa833.
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 85.48% 84.31% -1.18%
==========================================
Files 6 6
Lines 434 408 -26
==========================================
- Hits 371 344 -27
- Misses 63 64 +1 |
|
Whoops. Gotta put codecov back in. |
ericdill
reviewed
May 10, 2017
| %%init_spark | ||
| application_name = "My Fancy App" | ||
| launcher.jars = ["file://some/jar.jar"] | ||
| launcher.master = "local[4]" |
There was a problem hiding this comment.
What in the world is this local[4] syntax?
There was a problem hiding this comment.
Spark syntax for how many cores to use. local[4] says "Please use 4 of my cores for the application master." local[*] says "TAKE ALL MY CORES PLZ!"
There was a problem hiding this comment.
Can you add that as a comment in the code?
ericdill
approved these changes
May 10, 2017
|
Going to merge what I've got, then carry on with documenting the other two modules in another PR. Thanks folks. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prelude to #28, 26, and #22 which will build atop this but that
I want to keep separate for easier review.