Refactor to reflect did-io v1.0, crypto-ld and jsigs. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrizagidulin
changed the title
|
(Rebasing on latest |
|
(prepping for an npm release) |
gannan08
reviewed
May 19, 2021
.eslintrc.js
Outdated
| extends: ['eslint-config-digitalbazaar'], | ||
| extends: [ | ||
| 'eslint-config-digitalbazaar', | ||
| // 'eslint-config-digitalbazaar/jsdoc' |
There was a problem hiding this comment.
Why is this disabled? This should be deleted entirely or re-enabled.
There was a problem hiding this comment.
Sure, I can remove it. (I added it in a disabled state mostly as a to-do item.)
| - run: npm install | ||
| - name: Run test with Node.js ${{ matrix.node-version }} | ||
| run: npm run test-node | ||
| # test-karma: |
There was a problem hiding this comment.
Are karma tests broken at the moment?
There was a problem hiding this comment.
@gannan08 - yeah, they are. This lib didn't have a karma suite before; I started to add it in this PR, but it still needs more work.
|
Merging into the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code to reflect changes in
did-io,crypto-ld, andjsonld-signatures.Addresses issue #54.
Depends on upstream PRs:
Major refactor, implement general DidDocument class. digitalbazaar/did-io#50Initial commit (extract from jsonld-signatures). digitalbazaar/ed25519-signature-2018#1Initial commit (extract from jsonld-signatures). digitalbazaar/jws-linked-data-signature#1Extract signature suites to separate repos. digitalbazaar/jsonld-signatures#109