Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configurable deployment strategy #163

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

h3rmanj
Copy link
Contributor

@h3rmanj h3rmanj commented Dec 19, 2024

addresses #162

This PR allows the consumer to specify and configure the deployment strategy, while keeping existing defaults.

@h3rmanj
Copy link
Contributor Author

h3rmanj commented Dec 19, 2024

Seems the lint job got affected by the rollout of Ubuntu 24 to ubuntu-latest, so I pinned ubuntu-22.04 for now. But should probably look into bumping the python version instead if the ct tool supports it.

@h3rmanj
Copy link
Contributor Author

h3rmanj commented Dec 19, 2024

Checked the readme for helm/chart-testing-action and just set the python version to their example.

Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) thanks

@juanpicado juanpicado merged commit ae60bea into verdaccio:master Dec 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants