Add errors-only output mode #2588
Conversation
|
@dobesv is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
| | hash-only | Show only the hashes of the tasks | | ||
| | new-only | Only show output from cache misses | | ||
| | errors-only | Only show output from task failures | | ||
| | none | Hides all task output | |
There was a problem hiding this comment.
Can you move docs to a separate PR? Since the feature won't be out until the next release, we'll hold onto the docs PR until then.
Co-authored-by: Mehul Kar <[email protected]>
|
Thanks for the review! I rolled back the docs changes and added a couple of tests. I'm not too familiar with the testing system and philosophy here so do let me know how to do the tests properly if I didn't do them right. |
…tput-mode-errors-only
|
I updated the test so it also has a task whose output is not shown except in the count of tasks run. |
| // OnError | ||
| // If output-mode is set to "errors-only", we'll have buffered output | ||
| // to disk without logging it. Now we can log that here. | ||
| func (tc TaskCache) OnError(terminal *cli.PrefixedUi, logger hclog.Logger) { |
There was a problem hiding this comment.
This is annoying, but lint requires the code comment to be a whole line starting with OnError. You can still break it up into multiple lines, but I guess specifically what you have here is not acceptable 🤦🏾 ...
Oh, uh thanks! I hadn't fixed the linter error, thanks for cleaning that up for me |
For users that are not that interested in all the output related cache hits/misses and the cached output of prior builds or even the new output from a new build step that's just print a count of files or something boring like that, this trims the output down to just the task that failed, if any.
Partial solution for #993