refactor(turbopack): Rewrite CollectiblesSource callsites to use OperationVc (part 3/3)

[bgw]

OperationVcs should be used with CollectiblesSource instead of Vcs because collectibles represent a side-effect or implicit extra return value of a function's execution.

Closes PACK-3720

[bgw]

• perf(turbo-tasks): Optionally schedule ResolveNative/ResolveTrait tasks as local tasks #69126
• refactor(turbo-tasks): Convert local Vcs to non-local Vcs when returning from task functions #74714
• refactor(turbopack/next-api): Make VcArc use OperationVc #74479
• refactor(turbopack): Rewrite CollectiblesSource callsites to use OperationVc (part 3/3) #74173 👈 (View in Graphite)
• refactor(turbopack): Rewrite CollectiblesSource callsites to use OperationVc (part 2/3) #74168
• refactor(turbopack): Remove last known (non-test) usages of unresolved vcs in turbo_tasks::value (!!!) #74713
• refactor(turbopack/next-core): Use ResolvedVc in PackagesGlobs #74712
• refactor(turbopack-core): Use ResolvedVc in ContextCondition #74711
• refactor(turbopack/next-core): Use ResolvedVc in VisitClientReferenceNodeState #74710
• refactor(turbopack-ecmascript): Use ResolvedVc in CodeGen type #74709
• refactor(turbopack-dev-server): Use ResolvedVc/NonLocalValue in RewriteType, remove all "local" opt-outs from structs #74708
• refactor(turbopack-dev-server): Remove unresolved Vc from DevHtmlEntry, use a named struct #74707
• refactor(turbopack-core): Remove remaining "local" value type opt-outs in turbopack-core #74706
• chore(turbopack): Delete some dead code that was using unresolved Vcs #74705
• refactor(turbopack/next-api): Implement NonLocalValue for TracedDiGraph and SingleModuleGraph #74506
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt3	Change
buildDuration	36.9s	32.3s	N/A
buildDurationCached	30.9s	26.8s	N/A
nodeModulesSize	417 MB	417 MB	✓
nextStartRea..uration (ms)	764ms	876ms	⚠️ +112ms

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt3	Change
5306-HASH.js gzip	53.4 kB	53.4 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.44 kB	5.44 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	241 B	242 B	N/A
main-HASH.js gzip	34.2 kB	34.2 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt3	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt3	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.57 kB	4.57 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt3	Change
_buildManifest.js gzip	749 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt3	Change
index.html gzip	524 B	523 B	N/A
link.html gzip	539 B	538 B	N/A
withRouter.html gzip	520 B	520 B	✓
Overall change	520 B	520 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt3	Change
edge-ssr.js gzip	129 kB	129 kB	N/A
page.js gzip	207 kB	207 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt3	Change
middleware-b..fest.js gzip	670 B	668 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.2 kB	31.2 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt3	Change
274-experime...dev.js gzip	322 B	322 B	✓
274.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	369 kB	369 kB	✓
app-page-exp..prod.js gzip	130 kB	130 kB	✓
app-page-tur..prod.js gzip	142 kB	142 kB	✓
app-page-tur..prod.js gzip	138 kB	138 kB	✓
app-page.run...dev.js gzip	357 kB	357 kB	✓
app-page.run..prod.js gzip	126 kB	126 kB	✓
app-route-ex...dev.js gzip	37.6 kB	37.6 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	39.2 kB	39.2 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.6 kB	11.6 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.7 kB	21.7 kB	✓
pages.runtim...dev.js gzip	27.5 kB	27.5 kB	✓
pages.runtim..prod.js gzip	21.7 kB	21.7 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.46 MB	2.46 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bgw/operationvc-collectibles-migration-pt3	Change
0.pack gzip	2.09 MB	2.1 MB	⚠️ +1.49 kB
index.pack gzip	75.2 kB	74.9 kB	N/A
Overall change	2.09 MB	2.1 MB	⚠️ +1.49 kB

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: dc1a41c

[ijjk]

Tests Passed

[bgw]

Merge activity

• Jan 13, 10:01 PM EST: A user merged this pull request with Graphite.