Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use consistent resolve extensions alias for compiler (#58725)
## What? Changes the default resolve extensions to be consistent between server/client compilation. Currently browser prefers `.mjs` then `.js` and the server compiler prefers `.js` then `.mjs`. I added that behavior back in 2018 before mjs/cjs extensions were fully baked and many npm libraries had incorrect usage of it (PR: #5898). In the new setup with ESM resolving in Node.js writing out the full extension is required for `.mjs` files, meaning this "magic resolving" of a file to `.mjs` is no longer correct. In the future we'll likely want to remove `.mjs` from the default list of resolve extensions to align with the Node.js ESM resolver a bit more. For now we have to keep it in order to not break existing applications that rely on that behavior, an example of that seems to be contentlayer. ## How? Removed the condition and aligned it on a single list instead of separate lists. <!-- Thanks for opening a PR! Your contribution is much appreciated.i To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
- Loading branch information