[build-output-api] Update On-Demand ISR example with expiration: false prerenders
#374
+129
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
67 Ignored Deployments
|
TooTallNate
reviewed
Aug 11, 2022
build-output-api/on-demand-isr/.vercel/output/functions/blog/[slug].prerender-config.json
Outdated
Show resolved
Hide resolved
build-output-api/on-demand-isr/.vercel/output/functions/blog/post-2.prerender-config.json
Outdated
Show resolved
Hide resolved
build-output-api/on-demand-isr/.vercel/output/functions/blog/post-1.prerender-config.json
Outdated
Show resolved
Hide resolved
| There is also an example of a blog that only generates new paths when triggered via On-Demand ISR with two initial posts that are prerendered. | ||
|
|
||
| - `/blog/[slug]` | ||
| - base post prerender that allows generating news paths via On-Demand ISR |
There was a problem hiding this comment.
Is there an API endpoint to trigger this? Or should we document a fetch() call example or something?
There was a problem hiding this comment.
Can add a revalidate endpoint for this similar to the other for clarity.
|
I also wonder if we should split this into a separate example ( |
Co-authored-by: Nathan Rajlich <[email protected]>
|
I'm not sure if we want to have a separate example for this as we've kinda sunset the ISG documentation in favor of the ISR docs to prevent confusion between the two. |
TooTallNate
approved these changes
Aug 11, 2022
TooTallNate
changed the title
expiration: false prerenders
okbel
pushed a commit
that referenced
this pull request
Aug 16, 2022
…se` prerenders (#374) * Update On-Demand ISR example with expiration: false prerenders * Apply suggestions from code review Co-authored-by: Nathan Rajlich <[email protected]> * Add revalidate link * fix match Co-authored-by: Nathan Rajlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an example of
expiration: falseprerenders to our On-Demand ISR example as we've had some questions about handling this. This is specifically demonstrating how On-Demand ISR can be used in combination withroutesto only generate paths via On-Demand ISR instead of whenever a user visits a new path.x-ref: vercel/vercel#8289 (reply in thread)
x-ref: slack thread
Deployed example can be seen here https://boa-on-demand-fysl8lh1b-ijjk-testing.vercel.app/blog/post-1
Demo URL
Type of Change
New Example Checklist
npm run new-examplewas used to create the example