-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page refresh firing before saveChat #326
Closed
athrael-soju
wants to merge
318
commits into
vercel:main
from
athrael-soju:Bug--Page-refresh-firing-before-saveChat
Closed
Page refresh firing before saveChat #326
athrael-soju
wants to merge
318
commits into
vercel:main
from
athrael-soju:Bug--Page-refresh-firing-before-saveChat
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import path for the getMissingKeys function was updated from '../actions' to '@/app/actions' to align with the project's import conventions and improve code clarity.
The code changes refactor the logic for saving a chat in the chat application. Instead of saving the chat after each streamed result, the chat is now saved only once it's done. This improves efficiency and prevents unnecessary saving.
@athrael-soju is attempting to deploy a commit to the Uncurated Tests Team on Vercel. A member of the Team first needs to authorize it. |
athrael-soju
changed the title
refactor: Save chat only once it's done
Page refresh firing before saveChat
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code changes refactor the logic for saving a chat in the chat application. Instead of saving the chat after each streamed result, the chat is now saved only once it's done.
This resolves #302