-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo docs #12
Demo docs #12
Conversation
18ce57b
to
deadc0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor nits, but nothing important. LGTM.
I think we shouldn't stash the CBOR files here. Instead we should create them as part of the demo flow from the templates. |
@thomas-fossati : Thank you for your review: Yes, both options of creating the CBOR files and using the existing ones from the given folder is given as part of the complete flow. So both are covered, as per my understanding. |
A demo should have a simple, linear flow. What we have at the moment is a forked flow, which doesn't add a lot of value but is more complex and therefore potentially confusing. |
Essentially this is a two stage demo: Stage -1: If one wishes to create/modify Supply Chain Endorsements, they need to follow part -1. Stage -2 : If one wishes to use Veraison Provisioning Service to provision existing endorsements and use verification service to verify the same they follow part -2. I will take feedback from community on this before making a long and single series of steps. |
That's exactly the point I'm trying to make: ATM there are two demos folded into one, and therefore the flow becomes complex / confusing. |
OK, I have clarified and added a separate section to be super clear and make it simple for reader now! Do not want everything in one README as it becomes too long! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All commands are working like charm. Coming to comments,Most are minor. Feel free to consider depending on their relevance or discard.
No description provided.