Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo docs #12

Merged
merged 7 commits into from
Sep 12, 2022
Merged

Demo docs #12

merged 7 commits into from
Sep 12, 2022

Conversation

yogeshbdeshpande
Copy link
Contributor

No description provided.

Copy link
Contributor

@setrofim setrofim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor nits, but nothing important. LGTM.

@thomas-fossati
Copy link
Contributor

I think we shouldn't stash the CBOR files here. Instead we should create them as part of the demo flow from the templates.

@yogeshbdeshpande
Copy link
Contributor Author

I think we shouldn't stash the CBOR files here. Instead we should create them as part of the demo flow from the templates.

@thomas-fossati : Thank you for your review: Yes, both options of creating the CBOR files and using the existing ones from the given folder is given as part of the complete flow. So both are covered, as per my understanding.

@thomas-fossati
Copy link
Contributor

I think we shouldn't stash the CBOR files here. Instead we should create them as part of the demo flow from the templates.

@thomas-fossati : Thank you for your review: Yes, both options of creating the CBOR files and using the existing ones from the given folder is given as part of the complete flow. So both are covered, as per my understanding.

A demo should have a simple, linear flow. What we have at the moment is a forked flow, which doesn't add a lot of value but is more complex and therefore potentially confusing.

@yogeshbdeshpande
Copy link
Contributor Author

yogeshbdeshpande commented Sep 6, 2022

I think we shouldn't stash the CBOR files here. Instead we should create them as part of the demo flow from the templates.

@thomas-fossati : Thank you for your review: Yes, both options of creating the CBOR files and using the existing ones from the given folder is given as part of the complete flow. So both are covered, as per my understanding.

A demo should have a simple, linear flow. What we have at the moment is a forked flow, which doesn't add a lot of value but is more complex and therefore potentially confusing.

Essentially this is a two stage demo:

Stage -1: If one wishes to create/modify Supply Chain Endorsements, they need to follow part -1.

Stage -2 : If one wishes to use Veraison Provisioning Service to provision existing endorsements and use verification service to verify the same they follow part -2.

I will take feedback from community on this before making a long and single series of steps.

@thomas-fossati
Copy link
Contributor

I think we shouldn't stash the CBOR files here. Instead we should create them as part of the demo flow from the templates.

@thomas-fossati : Thank you for your review: Yes, both options of creating the CBOR files and using the existing ones from the given folder is given as part of the complete flow. So both are covered, as per my understanding.

A demo should have a simple, linear flow. What we have at the moment is a forked flow, which doesn't add a lot of value but is more complex and therefore potentially confusing.

Essentially this is a two stage demo:

Stage -1: If one wishes to create/modify Supply Chain Endorsements, they need to follow part -1.

Stage -2 : If one wishes to use Veraison Provisioning Service to provision existing endorsements and use verification service to verify the same they follow part -2.

I will take feedback from community on this before making a long and single series of steps.

That's exactly the point I'm trying to make: ATM there are two demos folded into one, and therefore the flow becomes complex / confusing.

@yogeshbdeshpande
Copy link
Contributor Author

I think we shouldn't stash the CBOR files here. Instead we should create them as part of the demo flow from the templates.

@thomas-fossati : Thank you for your review: Yes, both options of creating the CBOR files and using the existing ones from the given folder is given as part of the complete flow. So both are covered, as per my understanding.

A demo should have a simple, linear flow. What we have at the moment is a forked flow, which doesn't add a lot of value but is more complex and therefore potentially confusing.

Essentially this is a two stage demo:
Stage -1: If one wishes to create/modify Supply Chain Endorsements, they need to follow part -1.
Stage -2 : If one wishes to use Veraison Provisioning Service to provision existing endorsements and use verification service to verify the same they follow part -2.
I will take feedback from community on this before making a long and single series of steps.

That's exactly the point I'm trying to make: ATM there are two demos folded into one, and therefore the flow becomes complex / confusing.

OK, I have clarified and added a separate section to be super clear and make it simple for reader now! Do not want everything in one README as it becomes too long!

Copy link

@nayavij nayavij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All commands are working like charm. Coming to comments,Most are minor. Feel free to consider depending on their relevance or discard.

@yogeshbdeshpande yogeshbdeshpande merged commit efb4afd into main Sep 12, 2022
@setrofim setrofim deleted the demo-docs branch July 6, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants