map severities

veracode · Mar 21, 2024 · 04c767e · 04c767e
1 parent 40cbced
commit 04c767e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 118 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -28966,37 +28966,6 @@ class Converter {
         };
     }
     issueToRule(issue) {
-        /*
-         {
-                  "id": "no-unused-vars",
-                  "shortDescription": {
-                    "text": "disallow unused variables"
-                  },
-                  "helpUri": "https://eslint.org/docs/rules/no-unused-vars",
-                  "properties": {
-                    "category": "Variables"
-                  }
-                }
-        */
-        let gh_severity;
-        if (issue.severity == 5) {
-            gh_severity = 10;
-        }
-        else if (issue.severity == 4) {
-            gh_severity = 7;
-        }
-        else if (issue.severity == 3) {
-            gh_severity = 4;
-        }
-        else if (issue.severity == 2) {
-            gh_severity = 2;
-        }
-        else if (issue.severity == 1) {
-            gh_severity = 1;
-        }
-        else {
-            gh_severity = 0;
-        }
         return {
             id: issue.cwe_id,
             name: issue.issue_type,
@@ -29005,7 +28974,6 @@ class Converter {
             },
             helpUri: "https://cwe.mitre.org/data/definitions/" + issue.cwe_id + ".html",
             properties: {
-                severity: gh_severity,
                 "security-severity": (0, utils_1.mapVeracodeSeverityToCVSS)(issue.severity),
                 category: issue.issue_type_id,
                 tags: [issue.issue_type_id]
@@ -29067,35 +29035,11 @@ class Converter {
             prototypeHash: flawMatch.prototype_hash,
         };
         // construct the issue
-        let gh_severity;
-        let gh_severity_name;
-        if (issue.severity == 5) {
-            gh_severity = 10;
-            gh_severity_name = "Critical";
-        }
-        else if (issue.severity == 4) {
-            gh_severity = 7;
-            gh_severity_name = "High";
-        }
-        else if (issue.severity == 3) {
-            gh_severity = 4;
-            gh_severity_name = "Medium";
-        }
-        else if (issue.severity == 2) {
-            gh_severity = 2;
-            gh_severity_name = "Low";
-        }
-        else if (issue.severity == 1) {
-            gh_severity = 1;
-            gh_severity_name = "Low";
-        }
-        else {
-            gh_severity = 0;
-        }
+        let ghrank = +(0, utils_1.mapVeracodeSeverityToCVSS)(issue.severity);
         return {
             // get the severity number to name
-            level: this.config.reportLevels.get(gh_severity),
-            rank: gh_severity,
+            level: this.config.reportLevels.get(issue.severity),
+            rank: ghrank,
             message: {
                 text: issue.display_text,
             },

diff --git a/src/Converter.ts b/src/Converter.ts
@@ -64,37 +64,6 @@ export class Converter {
     }
 
     private issueToRule(issue: Issue): Sarif.ReportingDescriptor {
-        /*
-         {
-                  "id": "no-unused-vars",
-                  "shortDescription": {
-                    "text": "disallow unused variables"
-                  },
-                  "helpUri": "https://eslint.org/docs/rules/no-unused-vars",
-                  "properties": {
-                    "category": "Variables"
-                  }
-                }
-        */
-       let gh_severity: number
-        if (issue.severity == 5){
-                gh_severity = 10
-        }
-        else if (issue.severity == 4){
-                gh_severity = 7
-        }
-        else if (issue.severity == 3){
-                gh_severity = 4
-        }
-        else if (issue.severity == 2){
-                gh_severity = 2
-        }
-        else if (issue.severity == 1){
-                gh_severity = 1
-        }
-        else {
-                gh_severity = 0
-        }
         return {
             id: issue.cwe_id,
             name: issue.issue_type,
@@ -103,7 +72,6 @@ export class Converter {
             },
             helpUri: "https://cwe.mitre.org/data/definitions/" + issue.cwe_id + ".html",
             properties: {
-                severity: gh_severity,
                 "security-severity": mapVeracodeSeverityToCVSS(issue.severity),
                 category: issue.issue_type_id,
                 tags: [issue.issue_type_id]
@@ -169,35 +137,12 @@ export class Converter {
         }
 
         // construct the issue
-        let gh_severity: number
-        let gh_severity_name: string
-        if (issue.severity == 5){
-                gh_severity = 10
-                gh_severity_name = "Critical"
-        }
-        else if (issue.severity == 4){
-                gh_severity = 7
-                gh_severity_name = "High"
-        }
-        else if (issue.severity == 3){
-                gh_severity = 4
-                gh_severity_name = "Medium"
-        }
-        else if (issue.severity == 2){
-                gh_severity = 2
-                gh_severity_name = "Low"
-        }
-        else if (issue.severity == 1){
-                gh_severity = 1
-                gh_severity_name = "Low"
-        }
-        else {
-                gh_severity = 0
-        }
+
+        let ghrank:number = +mapVeracodeSeverityToCVSS(issue.severity)
         return {
             // get the severity number to name
-            level: this.config.reportLevels.get(gh_severity),
-            rank: gh_severity,
+            level: this.config.reportLevels.get(issue.severity),
+            rank: ghrank,
             message: {
                 text: issue.display_text,
             },