REL 1.24 - Set secure parameter for xslt transformation #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlwilson
reviewed
Mar 15, 2024
| factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true); | ||
| factory.setAttribute(XMLConstants.ACCESS_EXTERNAL_STYLESHEET, "file"); | ||
| } catch (TransformerConfigurationException ignored) { | ||
| LOGGER.log(Level.WARNING, "Unable to secure xsl transformer"); |
There was a problem hiding this comment.
Is a warning log message enough here? It might be better to generate a signal that could let the CLI or GUI know so they can inform the user. Most GUI users will never see the log message I guess.
There was a problem hiding this comment.
As I understand it, this exception throws in the case of unsupported features and attributes, and for FEATURE_SECURE_PROCESSING and ACCESS_EXTERNAL_STYLESHEET it should never happen
MaximPlusov
force-pushed
the
secure_xslt_release1.24
branch
from
8f9c40b to
72298e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.