Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/error on no server #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

allevo
Copy link
Contributor

@allevo allevo commented May 27, 2016

If "_getJobServer" method doesn't return a valid JobServer, an error is emitted.
The event could be fired before any 'error' event listeners are attached.
This could crash the process.

Using nextTick, the developer is able to add an 'error' handler.

On connect method, the callback should be called only one time. The security guard is a good thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant