Merge next into Fred deprecate closer and do not delete class (used in plugins) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could not resist fixing the broken javadoc tag.
Show GitHub Actions status using shields.io
Wrapper validation now hosted at gradle/actions repo.
These have been around since 2011. * The realtime parameter of getRoutingBackedOffUntil was set to `true` for both realtime and bulk. * The bulk backoff parameter in getPeerNodeStatus was not used due to it having the wrong name (the equally named field was used instead). Fixes db3329d
While beneficial for memory usage, reusing mutable objects may lead to all kinds of data consistency issues. It's just not worth saving the few bytes.
The underlying byte[] is mutable and could accidentally be changed after instantiation of the wrapper object. To ensure that the hashCode or the (natural or fast) order of the object does not change, the data must be copied defensively.
Fixes bug 01956
Fixes bug 06142 and 06087
These are files with merge issues against next.
This required quite a few manual fixes.
This reverts commit f4fed4c. We cannot remove the Closer, because it may be used in plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the fred-deprecated-closer branch to next. It also reverts the removal of the
Closerclass, because that’s used from plugins.After finishing the review of hyphanet#830 I’d love to merge it. For that we’ll need this updated to next — this PR does that.
For the review see hyphanet#830 (comment)
The big changes for updating to next are:
Please check whether they are OK and merge them into your branch. If they are, we can merge For the review see hyphanet#830 into next.