This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
Don't use the deprecated .selector method #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method ".selector" of jQuery selector has been removed from jQuery 3 [1]. At [1] it is said: "These properties were deprecated in jQuery 1.9, as they were only used for the obsolete .live() method and have never accurately represented the context or selector for the current collection." In this patch instead of using selector based indexing of the set of spies, we save a selector object for each spy and then check if passed selector matches the saved one using the ".is" jQuery method [2]. This way we find a matching spy among the set of spies. This patch improves support of jQuery v3 by jasmine-jquery. [1] https://jquery.com/upgrade-guide/3.0/#breaking-change-deprecated-context-and-selector-properties-removed [2] https://api.jquery.com/is/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method ".selector" of jQuery selector has been removed from
jQuery 3 [1].
At [1] it is said:
"These properties were deprecated in jQuery 1.9, as they were
only used for the obsolete .live() method and have never accurately
represented the context or selector for the current collection."
In this patch instead of using selector based indexing of the set of spies,
we save a selector object for each spy and then check if passed
selector matches the saved one using the ".is" jQuery method [2]. This way we
find a matching spy among the set of spies.
This patch improves support of jQuery v3 by jasmine-jquery.
[1] https://jquery.com/upgrade-guide/3.0/#breaking-change-deprecated-context-and-selector-properties-removed
[2] https://api.jquery.com/is/