This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
Improve toHaveAttr #256
Closed
Improve toHaveAttr #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cause of failure. Different error messages if * element not found * attribute not found * incorrect attribute value See issue velesin#184
|
Thanks for improving my initial work 👍 |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the
toHaveAttrmethod building on @jesperronn's work (in #187).Relevant discussions:
Sorry about adding the
bower_componentsto.gitignorein this pull req, it should really be separate.If you've got a better way of testing failing matchers, or test cases that should be added please let me know. I'm quite uncomfortable not having tests!