蛍光マーカーURLPopoverからPopoverに変更 #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URLPopoverからPopoverに変更 関連 : WordPress/gutenberg#34680
shimotmk
changed the title
mthaichi
reviewed
Jan 19, 2022
| value={value} | ||
| className="components-inline-color-popover" | ||
| className="components-inline-color-popover components-inline-color-popover" |
There was a problem hiding this comment.
@shimotmk ここは同じclass名(components-inline-color-popover)を追加してますが、vk- 系のクラスの誤りでしょうか。paddingが無かったので、それは別ブランチかなと思ってたんですが、ご確認をば。
There was a problem hiding this comment.
@mthaichi
確認ありがとうございます
修正しました
There was a problem hiding this comment.
@shimotmk paddingの調整は別ブランチで行いますか？
であれば、マージしておきます。
ここで併せてやっちゃっても問題ないような気がしますが、おまかせします。
・・・あ、paddingの調整はインライン文字列の方にいれるのかな。
一応確認です。
There was a problem hiding this comment.
@mthaichi
paddingのcss追加は別ブランチでやりますー
mthaichi
changed the title
shimotmk
changed the title
Popover独自のクラス名を追加
shimotmk
changed the title
mthaichi
changed the title
mthaichi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline font sizeで使用しているURLPopoverからPopoverに変更しました
5.8,5.9で問題がないか確認お願いします
fix: #954
related : #962 #969