Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【再調整】タブブロック #429

Closed
wants to merge 66 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
38520fe
huskey
drill-lancer Mar 26, 2021
f888f75
sss
drill-lancer Mar 26, 2021
6b2362c
不要?
drill-lancer Mar 26, 2021
1d70731
husky
drill-lancer Mar 26, 2021
e0405fe
テスト
drill-lancer Mar 26, 2021
e5b0bb9
test
drill-lancer Mar 26, 2021
ba996c0
lint
drill-lancer Mar 26, 2021
00021d7
test
drill-lancer Mar 26, 2021
d259669
hook
drill-lancer Mar 26, 2021
279723d
delete pre-commit
drill-lancer Mar 26, 2021
0ee88bc
形だけ
drill-lancer Mar 26, 2021
7ac13dd
ncu
drill-lancer Mar 30, 2021
dff895b
tab block temp
drill-lancer Mar 30, 2021
9354067
tab
drill-lancer Mar 30, 2021
64c9a09
コミット
drill-lancer Mar 30, 2021
6f32026
lint
drill-lancer Mar 30, 2021
4ee5d37
parent
drill-lancer Mar 30, 2021
4242155
push
drill-lancer Mar 30, 2021
4ca4a24
edit
drill-lancer Apr 1, 2021
95c6d1e
Merge branch 'master' into add/block/tab-block
drill-lancer Apr 1, 2021
9e24b8e
package.json
drill-lancer Apr 1, 2021
8551bee
lint
drill-lancer Apr 1, 2021
6255b69
innerblock
drill-lancer Apr 1, 2021
956a2eb
save 関数
drill-lancer Apr 2, 2021
8dbfd3b
修正
drill-lancer Apr 2, 2021
c65bd54
test
drill-lancer Apr 2, 2021
7a0f2f4
解決
drill-lancer Apr 2, 2021
0b9e5c3
コンソールエラーは出なくなったがテストで落ちる
drill-lancer Apr 2, 2021
90ea748
変更
drill-lancer Apr 2, 2021
3375fb5
Merge branch 'master' into add/block/tab-block
drill-lancer Apr 6, 2021
3ab2346
add active class
drill-lancer Apr 6, 2021
1a260a1
fix some
drill-lancer Apr 6, 2021
ae81458
fix some
drill-lancer Apr 6, 2021
efeef2f
enqueue.js
drill-lancer Apr 6, 2021
5c89891
test
drill-lancer Apr 6, 2021
1032509
Merge branch 'master' of github.com:vektor-inc/vk-blocks-pro into add…
drill-lancer Apr 15, 2021
1da9221
書き換え
drill-lancer Apr 15, 2021
b6e337b
Tree Shaking
drill-lancer Apr 15, 2021
0112955
修正
drill-lancer Apr 16, 2021
bb44812
feat / tab: style.scss追加
goutetsuguma May 27, 2021
b0777a3
直接編集できるように
drill-lancer May 28, 2021
55bb6a4
tab-item にデフォルトで段落ブロックを挿入
drill-lancer May 28, 2021
9414972
Merge branch 'master' of github.com:vektor-inc/vk-blocks-pro into add…
drill-lancer May 28, 2021
022beda
fix core/editor to core/block-editor
drill-lancer May 28, 2021
47394e4
JS を有効化してみたが・・・
drill-lancer May 28, 2021
5531853
fix ul がなかったらCSS は反映されないよね
drill-lancer May 28, 2021
d967ed8
戻し
drill-lancer May 28, 2021
b615022
fix ul がなかったら css は反映されないよね
drill-lancer May 28, 2021
d1811db
Merge branch 'add/block/tab-block' of github.com:vektor-inc/vk-blocks…
drill-lancer May 28, 2021
4ce05eb
編集画面で最後にクリックしたタブからフロント画面でも開始
drill-lancer May 28, 2021
ab66485
feat: tab:css修正
goutetsuguma May 28, 2021
26a5d48
Merge pull request #535 from vektor-inc/wip/add-editor-js-tab
goutetsuguma May 29, 2021
8a92f94
fix 予めタブアイテムを2つ設置するように
drill-lancer May 31, 2021
be6ec2b
fix: 編集画面で最後にクリックしたタブが反映されるように
drill-lancer May 31, 2021
1353352
fix : tab/edit コメント
drill-lancer May 31, 2021
e43be6e
fix: lint
drill-lancer May 31, 2021
995ddb4
feat / tab-block:スタイル追加
goutetsuguma Jun 4, 2021
87f4dea
lint & 幅切り替え
drill-lancer Jun 7, 2021
f86f27a
エラー処理
drill-lancer Jun 7, 2021
d384b0b
lint
drill-lancer Jun 7, 2021
a02d988
コメントアウト部分修正
drill-lancer Jun 7, 2021
de2f520
Merge branch 'master' of github.com:vektor-inc/vk-blocks-pro into add…
drill-lancer Jun 7, 2021
bc0ac9d
build & lint
drill-lancer Jun 7, 2021
1dcbc54
Merge branch 'master' of github.com:vektor-inc/vk-blocks-pro into add…
drill-lancer Sep 13, 2021
ec87938
fix: tab-block
drill-lancer Sep 13, 2021
f4274e1
fix / tab : コンフリクト解消&各種調整
kurudrive May 1, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module.exports = {
extends: [ 'plugin:@wordpress/eslint-plugin/recommended' ],
extends: ['plugin:@wordpress/eslint-plugin/recommended'],
rules: {
'import/no-unresolved': 'off',
'import/no-extraneous-dependencies': 'off',
Expand Down
61 changes: 61 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
## チケットへのリンク / 変更の理由(元のissueがあればリンクを貼り付ければOK)


## どういう変更をしたか?

* このプルリクで変更した事を記載してください


## 実装者の確認事項

実装者はレビュワーに回す前に以下の事を確認してチェックをつけてください。

- [ ] 複数の意図の変更 ( 機能の不具合修正 + 別の機能追加など ) を含んでいないか?
- [ ] Files changed (変更ファイル)の内容は目視で確認したか?
- [ ] readme.txt に変更内容は書いたか?
- [ ] 本当にちゃんと確認をしたか?

## プログラムの変更の場合

テストを書かないのは普通ではありません。書けるテストは極力書くようにしてください。

- [ ] 書けそうなテストは書いたか?

## 変更内容について何を確認したか、どういう方法で確認をしたかなど

実装者が確認した手順を箇条書きで記載してください。

*
*
*

## 確認URL

( どこかのデモサイトかテストサーバーにデプロイ済みなどで確認できる場合はそのURL )

## レビュワーに回す前の確認事項

- [ ] 実装者はこのテンプレートのチェック項目をちゃんと確認してチェックしたか?

## レビュワー確認方法・確認内容など

レビュワーがどういう手順で何を確認して欲しいかを記載してください。

*
*
*

---

## レビュワー向け

### レビュワーが確認して変更が反映されていない場合の確認事項

レビューしてみて意図した動作をしない場合は再度ビルドするなど以下の項目を確認してください。

* プルしたか?
* ビルドしたか?
* ビルドしたディレクトリは正しいか(別の開発環境のディレクトリを見ていないか)?
* npm install したか?
* composer install したか?
* キャッシュをクリアして確認したか?
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ name: Deprecated Test and Lint
on:
push:
branches:
- master
- develop
pull_request:
branches:
- master
- develop

env:
plugin_name: vk-blocks-pro
Expand Down Expand Up @@ -39,10 +39,12 @@ jobs:

- name: Install NPM Scripts
run: npm install
- name: Install Composer Package ( no-dev )
run: composer install --no-dev
- name: Install @wordpress/env
run: npm install -g @wordpress/env
- name: Run @wordpress/env
run: wp-env start
run: npx wp-env start
- name: Install WP-CLI
run: |
curl -O https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar
Expand Down
21 changes: 0 additions & 21 deletions .github/workflows/create_trello_card_when_issue_opened.yml

This file was deleted.

13 changes: 8 additions & 5 deletions .github/workflows/deploy-free.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,16 @@ name: Deploy to VK Blocks Free
on:
push:
tags:
- "[0-9]+.[0-9]+.[0-9]+"
- "pre_[0-9]+.[0-9]+.[0-9]+.[0-9]+"

env:
plugin_name: vk-blocks-pro
GIT_TOKEN: ${{ secrets.ACCESSTOKEN_FOR_VK_BLOCKS_FREE }}
GIT_USER: ${{ secrets.GIT_USER }}
GIT_REPOSITORY: ${{ secrets.GIT_REPOSITORY }}

# 無料版のリポジトリをPro版の中で一旦 clone して、bin/deploy-free.sh で処理する

jobs:
build:

Expand All @@ -38,10 +41,10 @@ jobs:
node-version: "${{ steps.nodenv.outputs.NODEVERSION }}"

- run: npm install -g npm
# 通常版をクローン
# 無料版を(Pro版の中に)クローン
- run: git clone https://${GIT_USER}:${GIT_TOKEN}@github.com/${GIT_REPOSITORY}
# VK BlocksのGithubにアクセスできるユーザーの設定
# VK Blocks の Githubにアクセスできるユーザーの設定
- run: git config --global user.email "[email protected]"
- run: git config --global user.name "bitbucket-piplines-vk-blocks-pro"
- run: git config --global user.name "github-workflows-vk-blocks-pro"
# # 無料版にデプロイするスクリプトにタグ名を引数で渡す。
- run: bash bin/deploy-free.sh $RELEASE_VERSION
- run: bash bin/deploy-free.sh $RELEASE_VERSION
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
name: PHP Unit Test
name: PHP Unit Test & Deploy develop

on:
push:
branches:
- develop
pull_request:
branches:
- master
- develop
- ^feature/.+

jobs:
php_unit:
name: php unit test
runs-on: ubuntu-latest
strategy:
matrix:
php: [7.2, 7.3, 7.4]
php: [7.3, 7.4]
services:
mysql:
image: mysql:5.7
Expand Down Expand Up @@ -48,11 +49,33 @@ jobs:
with:
php-version: ${{ matrix.php }}
- name: install npm scripts
run: npm install
- name: install Composer Package
run: composer install
- name: Install WP-CLI
run: |
npm install
npm install -g @wordpress/env
- name: install composer packages
run: wp-env destroy
- run: wp-env start
- run: wp-env run composer 'composer install'
- run: wp-env run phpunit 'phpunit -c /var/www/html/wp-content/plugins/vk-blocks-pro/phpunit.xml.dist --verbose'
curl -O https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar
chmod +x wp-cli.phar
mv wp-cli.phar /usr/local/bin/wp

# dist の中で build は実行している
- name: Build and Dist
run: npm run dist

# PHPUnit
- name: Run @wordpress/env
run: npx wp-env start
- name: PHP Unit Test
run: npm run phpunit

# Deploy test server
- name: Deploy to test server [ Deprecated ]
uses: burnett01/[email protected]
with:
switches: -avzr
path: /dist/vk-blocks-pro/
remote_path: /home/vs4/www/vk-block-test/wp-content/plugins/vk-blocks-pro/
remote_host: ${{ secrets.DEPLOY_HOST_VS4 }}
remote_port: ${{ secrets.DEPLOY_PORT_VS4 }}
remote_user: ${{ secrets.DEPLOY_USER_VS4 }}
remote_key: ${{ secrets.DEPLOY_KEY_VS4 }}
102 changes: 102 additions & 0 deletions .github/workflows/release-github-and-deploy-test-sv.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
name: Release GitHub and Deploy to test server
on:
push:
tags:
- "pre_[0-9]+.[0-9]+.[0-9]+.[0-9]+"

env:
plugin_name: vk-blocks-pro

jobs:
release:
name: release
runs-on: ubuntu-latest
steps:

# [ Start ] pre_ リリース と 本リリースで同じ処理 ##########################################

- uses: actions/checkout@v2

# get the node version from the .node-version file
- name: Read .node-version
run: echo "##[set-output name=NODEVERSION;]$(cat .node-version)"
id: nodenv

# setup node based on the version from the .node-version file, fetched in the previous step
- name: Setup Node.js (.node-version)
uses: actions/setup-node@v1
with:
node-version: "${{ steps.nodenv.outputs.NODEVERSION }}"

- name: Install NPM Scripts
run: npm install

# ビルドで翻訳処理があるため wp-env が必要
- name: Setup PHP 7.4
uses: shivammathur/setup-php@v2
with:
php-version: 7.4
- name: Install Composer Package
run: composer install
- name: Install @wordpress/env
run: npm install -g @wordpress/env
- name: Run @wordpress/env
run: wp-env start
- name: Install WP-CLI
run: |
curl -O https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar
chmod +x wp-cli.phar
mv wp-cli.phar /usr/local/bin/wp

- name: Make Distribution
# npm run dist の中で npm run build して composer install --no-dev した上で dist して ( compose install しなおして ) いる
# build 漏れの状態で dist してしまう事がないように dist の中に build を含めている
run: |
npm run dist
cd dist/ && zip -r ${{ env.plugin_name }}.zip ${{ env.plugin_name }}/ && mv ${{ env.plugin_name }}.zip ${GITHUB_WORKSPACE}
- run : test -e ${{ env.plugin_name }}.zip

# [ End ] pre_ リリース と 本リリースで同じ処理 ##########################################

- name: Create GitHub Release
id: create_release
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ github.ref }}
release_name: Release ${{ github.ref }}
draft: false
prerelease: false
- name: Upload Release Asset
id: upload-release-asset
uses: actions/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: ${{ env.plugin_name }}.zip
asset_name: ${{ env.plugin_name }}.zip
asset_content_type: application/zip

- name: Deploy to test server [ VK Blocks Pro (Single) ]
uses: burnett01/[email protected]
with:
switches: -avzr
path: /dist/vk-blocks-pro/
remote_path: /home/vs4/www/test/vk-blocks-pro/wp-content/plugins/vk-blocks-pro/
remote_host: ${{ secrets.DEPLOY_HOST_VS4 }}
remote_port: ${{ secrets.DEPLOY_PORT_VS4 }}
remote_user: ${{ secrets.DEPLOY_USER_VS4 }}
remote_key: ${{ secrets.DEPLOY_KEY_VS4 }}

- name: Deploy to test server [ Lightning G3 Pro ]
uses: burnett01/[email protected]
with:
switches: -avzr
path: /dist/vk-blocks-pro/
remote_path: /home/vs4/www/test/lightning-g3-pro/wp-content/plugins/vk-blocks-pro/
remote_host: ${{ secrets.DEPLOY_HOST_VS4 }}
remote_port: ${{ secrets.DEPLOY_PORT_VS4 }}
remote_user: ${{ secrets.DEPLOY_USER_VS4 }}
remote_key: ${{ secrets.DEPLOY_KEY_VS4 }}
28 changes: 21 additions & 7 deletions .github/workflows/deploy.yml → .github/workflows/release-vws.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ name: Deploy to VWS
on:
push:
tags:
- "[0-9]+.[0-9]+.[0-9]+"
- "[0-9]+.[0-9]+.[0-9]+.[0-9]+"

env:
plugin_name: vk-blocks-pro

Expand All @@ -16,6 +17,9 @@ jobs:
runs-on: ubuntu-latest

steps:

# [ Start ] pre_ リリース と 本リリースで同じ処理 ##########################################

- uses: actions/checkout@v2

# get the node version from the .node-version file
Expand All @@ -28,12 +32,17 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: "${{ steps.nodenv.outputs.NODEVERSION }}"

- name: Install NPM Scripts
run: npm install

# ビルドで翻訳処理があるため wp-env が必要
- name: Setup PHP 7.4
uses: shivammathur/setup-php@v2
with:
php-version: 7.4
- name: Install NPM Scripts
run: npm install
- name: Install Composer Package
run: composer install
- name: Install @wordpress/env
run: npm install -g @wordpress/env
- name: Run @wordpress/env
Expand All @@ -43,12 +52,17 @@ jobs:
curl -O https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar
chmod +x wp-cli.phar
mv wp-cli.phar /usr/local/bin/wp
- name: Build
run: npm run build

- name: Make Distribution
run: |
npx gulp dist
# npm run dist の中で npm run build して composer install --no-dev した上で dist して ( compose install しなおして ) いる
# build 漏れの状態で dist してしまう事がないように dist の中に build を含めている
run: |
npm run dist
cd dist/ && zip -r ${{ env.plugin_name }}.zip ${{ env.plugin_name }}/ && mv ${{ env.plugin_name }}.zip ${GITHUB_WORKSPACE}
- run : test -e ${{ env.plugin_name }}.zip

# [ End ] pre_ リリース と 本リリースで同じ処理 ##########################################

- name: rsync deployments
uses: burnett01/[email protected]
with:
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/*.html
node_modules/
build/
dist/
inc/vk-blocks/build/*
editor-css/editor-block-build.scss
Expand All @@ -17,3 +18,4 @@ src/blocks/_pro/**/style.css.map
test/e2e-tests/fixtures/blocks/*.json
test/e2e-tests/fixtures/blocks/*.serialized.html
.vscode/
artifacts/
Loading