-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ VK Twitter ] ウィジェット名にNot recommendedを追加 #1119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurudrive
requested changes
Oct 30, 2024
Co-authored-by: Hidekazu Ishikawa <[email protected]>
Co-authored-by: Hidekazu Ishikawa <[email protected]>
Co-authored-by: Hidekazu Ishikawa <[email protected]>
@kurudrive |
kurudrive
approved these changes
Oct 30, 2024
確認しました。問題なかったのでマージします。 |
drill-lancer
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットへのリンク / 変更の理由(元のissueがあればリンクを貼り付ければOK)
#1118
どういう変更をしたか?
ウィジェット非推奨表記の準備 の書き方合わせて、ウィジェットの名称と説明新たにメソッド化して非推奨表記を追加しました。
変更前 Before
変更後 After
ソースコードについて
デザイン・UI
プログラムの変更の場合
テストを書かないのは普通ではありません。書けるテストは極力書くようにしてください。
書いていない場合は書かない理由を記載してください。
→ NameとDiscriptionに説明を加えただけなのでスキップしました。必要であれば書き加えます。
その他
変更内容について何を確認したか、どういう方法で確認をしたかなど
外観 > ウィジェットにて 「VK Twitter」を配置し、以下を確認。
確認URL
( どこかのデモサイトかテストサーバーにデプロイ済みなどで確認できる場合はそのURL )
レビュワーの確認方法・確認する内容など
実装者と同じ確認を行ってください。
レビュワーに回す前の確認事項
レビュワー向け
確認して変更が反映されていない場合の確認事項