fix issue #160: validateVarType parsing numbers #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
si3nloong
suggested changes
Sep 30, 2021
| if v.Type.NamedType == "Int" { | ||
| n, err := jsonNumber.Int64() | ||
| if err != nil { | ||
| return nil, gqlerror.ErrorPathf(validator.path, "cannot use value %s as %s", n, v.Type.NamedType) |
There was a problem hiding this comment.
I see you have typo here, it should be
gqlerror.ErrorPathf(validator.path, "cannot use value %d as %s", n, v.Type.NamedType)Because n is not a string, it's a int64
|
Rebased (and fixed typo per @si3nloong comment) in #216 so closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix issue #160, which I run into as well.
When we find a variable which is
json.Number, depending on the variable type request, we'll extract either the Int64 value, or the float value from thejson.Number.This should work well with gqlgen, which uses the json decoder
UseNumberfunction to decode numbers.https://github.com/99designs/gqlgen/blob/master/graphql/handler/transport/http_get.go#L76
Let me know if I can help make it any better, or if you have any better solution for this problem.