fix cache moment

vein-lang · Aug 21, 2024 · 370aa8f · 370aa8f
1 parent 91e00a1
commit 370aa8f
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 9 deletions.
diff --git a/src/controllers/PackageContentController.cs b/src/controllers/PackageContentController.cs
@@ -24,7 +24,7 @@ public async Task<ActionResult<PackageVersionsResponse>> GetPackageVersionsAsync
         if (versions == null)
             return NotFound();
 
-        cache.Set($"@/packages/{id}/version.json", versions, TimeSpan.FromMinutes(15));
+        cache.Set($"@/packages/{id}/version.json", versions, TimeSpan.FromMinutes(5));
 
         return Json(versions);
     }
@@ -84,8 +84,7 @@ public async Task<IActionResult> DownloadReadmeAsync(string id, string version,
 
         var result = await reader.ReadToEndAsync(cancellationToken);
 
-        cache.Set($"@/packages/{id}/{version}/readme", result,
-            ver.HasMetadata ? TimeSpan.FromMinutes(15) : TimeSpan.FromHours(6));
+        cache.Set($"@/packages/{id}/{version}/readme", result, TimeSpan.FromHours(6));
 
         return Content(markdownService.GetHtmlFromMarkdown(result).Content, "text/html");
     }

diff --git a/src/controllers/SearchController.cs b/src/controllers/SearchController.cs
@@ -20,13 +20,16 @@ public class SearchController(
     [HttpGet("@/package/{name}/{version}")]
     public async Task<ActionResult<Package>> FindByName(string name, string version, [FromQuery] bool includeUnlisted = false)
     {
-        if (cache.TryGetValue((name, version), out Package package))
+        if (string.IsNullOrEmpty(version))
+            return BadRequest(new { message = "version cannot be null" });
+
+        if (cache.TryGetValue((name, version), out Package? package))
             return Json(package);
 
         var ver = version switch
         {
-            "latest" or null => new (0, 0, 0, 0, "", "latest"),
-            "next"           => new (0, 0, 0, 0, "", "next"),
+            Package.LatestTag or null => new (0, 0, 0, 0, "", Package.LatestTag),
+            Package.NextTag           => new (0, 0, 0, 0, "", Package.NextTag),
             not null         => NuGetVersion.Parse(version)
         };
 
@@ -39,9 +42,10 @@ public async Task<ActionResult<Package>> FindByName(string name, string version,
             ? urlGenerator.GetPackageIconDownloadUrl(result.Name, result.Version)
             : result.Icon;
 
+        if (!version!.Equals(Package.LatestTag) && !version.Equals(Package.NextTag))
+            return Json(result);
 
-        cache.Set((name, version), result, ver.HasMetadata ? TimeSpan.FromMinutes(15) : TimeSpan.FromDays(2));
-
+        cache.Set((name, version), result, TimeSpan.FromDays(2));
         return Json(result);
     }
 

diff --git a/src/controllers/StateController.cs b/src/controllers/StateController.cs
@@ -30,7 +30,7 @@ public async Task<IActionResult> GetState()
             popular_packages = popular
         };
 
-        cache.Set("@/state", result, TimeSpan.FromHours(12));
+        cache.Set("@/state", result, TimeSpan.FromHours(24));
 
         return Json(result);
     }

diff --git a/src/logic/entities/Package.cs b/src/logic/entities/Package.cs
@@ -30,4 +30,9 @@ public record Package : PackageManifest
 
     [JsonProperty("hasServicedPackage")]
     public bool HasServicedPackage { get; set; }
+
+
+    public const string LatestTag = "latest";
+    public const string NextTag = "next";
+
 }