Enhancement: Clean up the Stdafx.h usage #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use a precompiled header. NOTE: This is the first step for a refactor of the headers. The next step would be to reduce what headers are used in any given implementation or header file.
|
still trying to figure out the vegasettings crash issue; but this compiles and behaves the same. It's all header changes and just simplifying things. Some testing still needed. |
| #include "CSopcodecollider.h" | ||
| #include "opcodeqsqrt.h" | ||
| #include "opcodeqint.h" | ||
| #include "vs_vector.h" |
There was a problem hiding this comment.
I actually just got rid of vs_vector a few days ago in one of my PRs. vs_vector was a mistake from the beginning. It inherits from std::vector, which is not intended to be inherited from. (std::vector doesn't have a virtual destructor.)
vs_vector was only ever used in one place (in this file). It can be replaced with std::vector again, I think. Then if we want to enforce bounds checking (which we probably should) we can change all occurrences of operator[] to .at().
|
Looks like the expected builds failed. |
royfalk
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use a precompiled header.
NOTE: This is the first step for a refactor of the headers. The next step would be to reduce what headers are used in any given implementation or header file.
Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.
Please answer the following:
Code Changes:
Issues:
Stdafx.h? #512Purpose: