Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix installer description paragraph - 0.9.x #985

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Fix installer description paragraph - 0.9.x #985

merged 4 commits into from
Jan 14, 2025

Conversation

stephengtuggy
Copy link
Contributor

Code Changes:

Issues:

Purpose:

  • What is this pull request trying to do? Fix the description of Vega Strike shown in the installers that are built, such as .deb installers, for example
  • What release is this for? 0.9.x
  • Is there a project or milestone we should apply this to? 0.9.x

@stephengtuggy stephengtuggy added bug Installer Installer-specific issues labels Jan 13, 2025
@stephengtuggy stephengtuggy added this to the 0.9.x milestone Jan 13, 2025
@stephengtuggy stephengtuggy self-assigned this Jan 13, 2025
@stephengtuggy stephengtuggy changed the title Fix install package description Fix install package description - 0.9.x Jan 13, 2025
@stephengtuggy stephengtuggy changed the title Fix install package description - 0.9.x Fix installer description paragraph - 0.9.x Jan 13, 2025
evertvorster
evertvorster approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@evertvorster evertvorster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.
Just on a side note, on Arch vegastrike is installed into /usr/share/vegastrike, ie: system-wide.
However, launching with "vs" does the proper thing in terms of finding where it is installed.

@stephengtuggy stephengtuggy merged commit dc1bfed into vegastrike:0.9.x Jan 14, 2025
24 checks passed
@stephengtuggy stephengtuggy deleted the fix/cpack_descrip_0.9.x branch January 14, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjamenMeyer BenjamenMeyer BenjamenMeyer approved these changes

@evertvorster evertvorster evertvorster approved these changes

@royfalk royfalk Awaiting requested review from royfalk

Assignees

@stephengtuggy stephengtuggy

Labels
bug Installer Installer-specific issues
Projects
None yet
Milestone
0.9.x
Development

Successfully merging this pull request may close these issues.
3 participants
@stephengtuggy @BenjamenMeyer @evertvorster