Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License Updates 0.9.x Part 3: Remaining .h files #1014

Open
wants to merge 2 commits into
base: 0.9.x
Choose a base branch
from

Conversation

stephengtuggy
Copy link
Contributor

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

Issues:

  • N/A?

Purpose:

  • What is this pull request trying to do? Update the copyleft headers in another group of 0.9.x source files, this time the remaining .h files (not opcode-related)
  • What release is this for? 0.9.x
  • Is there a project or milestone we should apply this to? 0.9.x

@stephengtuggy stephengtuggy added this to the 0.9.x milestone Jan 23, 2025
@stephengtuggy stephengtuggy self-assigned this Jan 23, 2025
@stephengtuggy stephengtuggy marked this pull request as ready for review January 23, 2025 03:07
Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check the non-trivial license additions; the license may be correct but we still need to ensure all the authors are included. Found one specifically but may have missed others.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review - originator: jhunt@jaja

@@ -1,20 +1,20 @@
/*
* mesh.h
*
* Copyright (C) 2001-2002 Daniel Horn and Alan Shieh
* Copyright (C) 2002-2019 Daniel Horn, klaussfreire, pheonixstorm, safemode, dan_w,
* ace123, jacks, and other Vega Strike contributors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly named contributors should probably remain explicitly named

*
* You should have received a copy of the GNU General Public License
* along with Vega Strike. If not, see <https://www.gnu.org/licenses/>.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplication

*
* You should have received a copy of the GNU General Public License
* along with Vega Strike. If not, see <https://www.gnu.org/licenses/>.
*/
/*
* A C-program for MT19937, with initialization improved 2002/1/26.
* Coded by Takuji Nishimura and Makoto Matsumoto.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a different license

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants