Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Display Engine Version Information #80

Conversation

BenjamenMeyer
Copy link
Member

Output the Engine Version and the Engine API Version for diagnostics.
A future PR can take are of checking for a minimum version, which
should be done against the Engine API Version.

Thank you for submitting a pull request and becoming a contributor to Vega Strike: Upon the Coldest Sea.

Please answer the following:

Code Changes:

Issues:

Purpose:

  1. Show how to use the new Engine Version information
  2. Validate that the Engine Assets can see the Engine Version Information
  3. Document the Engine Version information in the logs

A future PR will need to add the minimum supported version information.

Output the Engine Version and the Engine API Version for diagnostics.
A future PR can take are of checking for a minimum version, which
should be done against the Engine API Version.
@BenjamenMeyer BenjamenMeyer added this to the 0.9.x milestone Oct 6, 2021
@BenjamenMeyer BenjamenMeyer requested review from stephengtuggy, Loki1950, nabaco and a team October 6, 2021 05:55
@BenjamenMeyer BenjamenMeyer self-assigned this Oct 6, 2021
@BenjamenMeyer
Copy link
Member Author

Waiting to merge this until after vegastrike/Vega-Strike-Engine-Source#578 is merged

@BenjamenMeyer BenjamenMeyer merged commit e76ff57 into vegastrike:master Oct 7, 2021
BenjamenMeyer added a commit to BenjamenMeyer/Privateer_Gold that referenced this pull request Apr 21, 2024
Output the Engine Version and the Engine API Version for diagnostics.
A future PR can take are of checking for a minimum version, which
should be done against the Engine API Version.

Port of vegastrike/Assets-Production#80
BenjamenMeyer added a commit to BenjamenMeyer/Privateer_Gold that referenced this pull request Apr 21, 2024
Output the Engine Version and the Engine API Version for diagnostics.
A future PR can take are of checking for a minimum version, which
should be done against the Engine API Version.

Port of vegastrike/Assets-Production#80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants