Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows-Release.yml: invoke CPack via CMake:… (0.10.x) #151

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Windows-Release.yml: invoke CPack via CMake:… (0.10.x) #151

merged 1 commit into from
Jan 28, 2025

Conversation

stephengtuggy
Copy link
Contributor

… cmake --build . --target package

Code Changes:

  • This is a CI/build system change only (and I have run the cmake command locally to make sure that it works)

Issues:

  • N/A

Purpose:

  • What is this pull request trying to do? Fix the Windows packaging of the vsUTCS Assets, for 0.10.x and following
  • What release is this for? 0.10.x
  • Is there a project or milestone we should apply this to? 0.10.x

@stephengtuggy stephengtuggy added this to the 0.10.x milestone Jan 23, 2025
@stephengtuggy stephengtuggy self-assigned this Jan 23, 2025
BenjamenMeyer
BenjamenMeyer approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might have to adjust with the cmake refactor on master/0.10.x

@stephengtuggy stephengtuggy merged commit 7200f9f into vegastrike:master Jan 28, 2025
11 checks passed
@stephengtuggy stephengtuggy deleted the win-pkging-0.10.x branch January 28, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjamenMeyer BenjamenMeyer BenjamenMeyer approved these changes

@royfalk royfalk Awaiting requested review from royfalk

Assignees

@stephengtuggy stephengtuggy

Labels
bug CI/CD
Projects
None yet
Milestone
0.10.x
Development

Successfully merging this pull request may close these issues.
2 participants
@stephengtuggy @BenjamenMeyer