Change default test from sequential to omnibus in adonis2() Issue 677
#681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a sequential test to an omnibus test
…quential tests as that was what was being tested prior to changes in vegandevs#677
…quential tests as that was what was being tested prior to changes in vegandevs#677
jarioksa
approved these changes
Aug 16, 2024
|
I've merged this and cherry-picked these 4 commits to the cran-2.6-6 branch and added a NEWS entry there. I should probably cherry pick that NEWS entry addition to the master branch too. |
|
cherry-picking won't work: cran-2.6-6 has |
|
Yeah; just found that out. I manually committed the news entry to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #677, this PR changes the default test from sequential (
by = "terms") to an omnibus test (by = NULL).I updated the code, the Rd, the examples, and the test code/output.
I didn't update the example reference output here in this PR to keep it simple and there are other changes in master.
If accepted, consider when we include it in a CRAN release. This is a breaking change, and while I can justify this change in terms of making the code base more consistent across functions, it is breaking. Should this go into a 2.7.0 or wait for a 3.0.0?
Thoughts?