Aitchison #498
Merged
Aitchison #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR adds to #460 |
Merged
|
Just following up on this; does this need merging in addition to #460 ? The comment by @antagomir suggests it is but I lost track of these things. |
|
Yes it does. This includes changes that were requested after merging #460 |
|
Ah, OK, apologies for not noticing that. We'll take a look at get this merged ASAP (it doesn't appear to be causing any problems with our checks) |
|
Everything looked fine; merged. Thanks @antagomir for these contributions and for bearing with us getting the "t"s crossed and the "i"s dotted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of this PR:
Switches to the suggested naming in #460 ie. "aitchison" and "robust.aitchison"
Removes ILR related parts that were in my earlier PR as the implementation was also simple and unoptimized. Better to add ILR more properly if a need will arise.
Updated tests and documentation accordingly w.r.t. 1-2
I think this PR should resolve all the remaining issues that there were.