Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mx_array_to_chunks: Increment the start index of chunk data by previous offset #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaglinux
Copy link

No description provided.

@jaglinux
Copy link
Author

@vegaluisjose Thanks for the code, really helps in understanding vdb on mlx framework.
For query_vdb.py, I see that the response is always same for any queries because the values of chunks are all same. Since the start index is not incrementing, whatever might be the score, the resulting index returns the same chunk.

@stronk7
Copy link

stronk7 commented Feb 21, 2024

Well spotted, @jaglinux . I can confirm that, without that change, the context passed is, 99% of times 100% useless. I just applied for it here and now and my results are way better, heh.

Ciao :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants