fix: updated types for projection fit #9260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
requested changes
Feb 15, 2024
There was a problem hiding this comment.
Great start. I ran yarn schema to update the schema and pushed it.
However, this changeset does not yet fix the issue that the valid feature collection is not accepted. Please update the types (maybe we need to change types in Vega, not sure) and add an example so we test compatibility.
|
@astrophie can you wrap up this pull request? |
|
Why did you close this? |
I wasn't able to get the example added in the src folder after a few attempts. I didn't think it was super necessary as the schema type fix from before seems to fix the bug, and that was already merged? |
|
Oh I missed that. What's the pull request or commit that fixed it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the TypeScript definition for the Projection interface to allow both Feature Collection objects and Feature arrays for the fit property.
Added API documentation in comments.
Fixes #7448