feat: use consistent quotes that don't need to be escaped #9234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
reviewed
Feb 19, 2024
| @@ -209,23 +209,26 @@ export function fieldFilterExpression(predicate: FieldPredicate, useInRange = tr | |||
| : rawFieldExpr; | |||
|
|
|||
| if (isFieldEqualPredicate(predicate)) { | |||
| return `${fieldExpr}===${predicateValueExpr(predicate.equal, unit)}`; | |||
| const equal = predicate.equal; | |||
| return `${fieldExpr} === ${predicateValueExpr(equal, unit)}`; | |||
There was a problem hiding this comment.
Let's change spacing in a separate pull request.
| } else if (isFieldValidPredicate(predicate)) { | ||
| return fieldValidPredicate(fieldExpr, predicate.valid); | ||
| const valid = predicate.valid; | ||
| return fieldValidPredicate(fieldExpr, valid); |
There was a problem hiding this comment.
Not really a need to define a variable for one use.
| } | ||
|
|
||
| function escapePathAccess(string: string) { | ||
| return string.replace(/(\[|\]|\.|'|")/g, '\\$1'); | ||
| } | ||
|
|
||
| function doubleQuotes2Single(string: string) { |
There was a problem hiding this comment.
No, we can't do this. It's too brittle and possibly introduces errors. If we want to change the quotes, we need to extend stringValue to accept a quote parameter.
domoritz
changed the title
|
Are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4112