Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link to valid bar chart example #9214

Merged
merged 1 commit into from
Dec 27, 2023
Merged

docs: link to valid bar chart example #9214

merged 1 commit into from
Dec 27, 2023

Conversation

luis261
Copy link
Contributor

@luis261 luis261 commented Dec 27, 2023

replace link leading to an invalid specification error message in the online editor

I was doing some research on which lib to use for visualizations in one of my side projects.
Stumbled upon Vega/Vega-Lite via https://github.com/altair-viz/altair and really liked what I saw in terms of the approach it takes to visualization.

When reading up on Vega-Lite, I noticed that this link in your README leads to an error message in the online editor: https://vega.github.io/editor/#/custom/vega-lite

This can be confusing, especially on mobile. I suggest swapping in a link to a simple example instead.

replace link leading to an invalid specification error message in the online editor
@luis261 luis261 marked this pull request as ready for review December 27, 2023 08:32
@luis261 luis261 requested a review from a team as a code owner December 27, 2023 08:32
@domoritz domoritz changed the title chore: link to valid bar chart example docs: link to valid bar chart example Dec 27, 2023
@domoritz
Copy link
Member

Thanks. Good idea. The current link sets the mode of the editor but I agree that it's nicer to show a working example.

@domoritz domoritz enabled auto-merge (squash) December 27, 2023 14:10
@luis261
Copy link
Contributor Author

luis261 commented Dec 27, 2023

Awesome, thank you for your swift response!

@domoritz domoritz disabled auto-merge December 27, 2023 18:29
@domoritz domoritz merged commit 07b13ab into vega:main Dec 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants