Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update deps and resolve issue with images in docs #9210

Merged
merged 4 commits into from
Dec 27, 2023
Merged

fix: update deps and resolve issue with images in docs #9210

merged 4 commits into from
Dec 27, 2023

Conversation

domoritz
Copy link
Member

Fixes #9151

@domoritz domoritz requested a review from a team as a code owner December 19, 2023 18:56
@domoritz domoritz changed the title chore: update deps fix: update deps and resolve issue with images in docs Dec 20, 2023
keckelt
keckelt reviewed Dec 22, 2023
View reviewed changes
Copy link
Contributor

@keckelt keckelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with images in docs is resolved by the bumped vega-embed version (6.24) which contains the fix from vega/vega-embed#1286

The new vega-tooltip version (v0.34) contains the baseUrl feature.

@domoritz
Copy link
Member Author

Yes. Does this look good?

@keckelt
Copy link
Contributor

keckelt commented Dec 27, 2023

I have removed the duplicates from package.json's devDependencies and ran yarn again.

@domoritz
Copy link
Member Author

Thank you. Good catch that my merge was broken.

@domoritz domoritz enabled auto-merge (squash) December 27, 2023 14:18
keckelt
keckelt approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@keckelt keckelt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

package.json Outdated Show resolved Hide resolved
@domoritz domoritz merged commit fc94297 into main Dec 27, 2023
10 checks passed
@domoritz domoritz deleted the dom/updates branch December 27, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keckelt keckelt keckelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing tooltip images in docs
2 participants
@domoritz @keckelt