Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boxplot default width to make it auto-adjustable #9175

Conversation

richardliu-db
Copy link
Contributor

@richardliu-db richardliu-db commented Nov 14, 2023

image
  • I can remove some irrelevant changes. I'm not sure if .lock file and others are expected or not.
  • the default bar config has the following type definition. Do we need to support ExprRef for BoxPlotConfig as well?
    • defaultBarConfig: RectConfig
    • interface RectConfig<ES extends ExprRef | SignalRef> extends RectBinSpacingMixins, MarkConfig
  • signal: "0.75 * bandwidth('x')" is just for demo purpose. Our goal is to use size: {band: 0.5}.

@richardliu-db richardliu-db marked this pull request as draft November 14, 2023 22:19
@richardliu-db richardliu-db changed the title Update boxplot default width Update boxplot default width to make it auto-adjustable Nov 14, 2023
@domoritz
Copy link
Member

Why did you close this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants