fix: use child signal for radius if faceted (#9232)

close #8754 I found that the range for radius using width and height without checking if the model is faceted https://github.com/vega/vega-lite/blob/c33f46bad7f80f779e463a8a36481f888f18e222/src/compile/scale/range.ts#L311-L314 --------- Co-authored-by: GitHub Actions Bot <[email protected]> Co-authored-by: Dominik Moritz <[email protected]>
vega · Jan 30, 2024 · e11af45 · e11af45
1 parent c33f46b
commit e11af45
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/compile/scale/range.ts b/src/compile/scale/range.ts
@@ -63,6 +63,7 @@ import {Explicit, makeExplicit, makeImplicit} from '../split';
 import {UnitModel} from '../unit';
 import {ScaleComponentIndex} from './component';
 import {durationExpr} from '../../timeunit';
+import {isFacetModel} from '../model';
 
 export const RANGE_PROPERTIES: (keyof Scale)[] = ['range', 'scheme'];
 
@@ -306,11 +307,12 @@ function defaultRange(channel: ScaleChannel, model: UnitModel): VgRange {
 
     case RADIUS: {
       // max radius = half od min(width,height)
+
       return [
         0,
         new SignalRefWrapper(() => {
-          const w = model.getSignalName('width');
-          const h = model.getSignalName('height');
+          const w = model.getSignalName(isFacetModel(model.parent) ? 'child_width' : 'width');
+          const h = model.getSignalName(isFacetModel(model.parent) ? 'child_height' : 'height');
           return `min(${w},${h})/2`;
         })
       ];