Skip to content

Commit

Permalink
fix: make isRectWithOffset check consistent
Browse files Browse the repository at this point in the history
  • Loading branch information
fandu-db committed Nov 9, 2023
1 parent 2b67c88 commit dc9d750
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/compile/scale/domain.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
SHARED_DOMAIN_OPS
} from '../../aggregate';
import {isBinning, isBinParams, isParameterExtent} from '../../bin';
import {getSecondaryRangeChannel, isScaleChannel, ScaleChannel} from '../../channel';
import {getSecondaryRangeChannel, isScaleChannel, isXorY, ScaleChannel} from '../../channel';
import {
binRequiresRange,
getBandPosition,
Expand Down Expand Up @@ -356,7 +356,7 @@ function parseSingleChannelDomain(
const data = model.requestDataName(DataSourceType.Main);

const bandPosition = getBandPosition({fieldDef, fieldDef2, markDef, config});
const isRectWithOffset = isRectBasedMark(mark) && bandPosition !== 0.5;
const isRectWithOffset = isRectBasedMark(mark) && bandPosition !== 0.5 && isXorY(channel);
return makeImplicit([
{
data,
Expand Down

0 comments on commit dc9d750

Please sign in to comment.