Try to add default value and fix tests

vega · Nov 11, 2023 · bd567d9 · bd567d9
1 parent 996a4c4
commit bd567d9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/compile/data/density.ts b/src/compile/data/density.ts
@@ -19,6 +19,7 @@ export class DensityTransformNode extends DataFlowNode {
     this.transform = duplicate(transform); // duplicate to prevent side effects
     const specifiedAs = this.transform.as ?? [undefined, undefined];
     this.transform.as = [specifiedAs[0] ?? 'value', specifiedAs[1] ?? 'density'];
+    this.transform.resolve = 'independent';
   }
 
   public dependentFields() {

diff --git a/test/compile/data/density.test.ts b/test/compile/data/density.test.ts
@@ -27,7 +27,7 @@ describe('compile/data/fold', () => {
         extent: [0, 10],
         minsteps: 25,
         maxsteps: 200,
-        resolve: 'shared',
+        resolve: 'independent',
         as: ['x', 'y']
       });
     });
@@ -58,10 +58,11 @@ describe('compile/data/fold', () => {
       });
     });
 
-    it('should add resolve shared if we group', () => {
+    it('should only add resolve "shared" if we set it explicitly', () => {
       const transform: Transform = {
         density: 'v',
-        groupby: ['a']
+        groupby: ['a'],
+        resolve: 'shared',
       };
       const density = new DensityTransformNode(null, transform);
       expect(density.assemble()).toEqual({