coverage actually passing

vega · Jan 26, 2024 · 46ad87e · 46ad87e
1 parent 38632c3
commit 46ad87e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/compile/scale/type.ts b/src/compile/scale/type.ts
@@ -117,8 +117,7 @@ function defaultType(
       } else if (isFieldDef(fieldDef) && fieldDef.timeUnit && normalizeTimeUnit(fieldDef.timeUnit).utc) {
         return 'utc';
       } else if (isTime(channel)) {
-        // return 'linear';
-        return 'band'; // TODO(jzong): when interpolation is implemented, this should be 'linear'
+        return 'linear';
       }
 
       return 'time';
@@ -135,8 +134,7 @@ function defaultType(
         // TODO: consider using quantize (equivalent to binning) once we have it
         return 'ordinal';
       } else if (isTime(channel)) {
-        // return 'linear';
-        return 'band'; // TODO(jzong): when interpolation is implemented, this should be 'linear'
+        return 'linear';
       }
 
       return 'linear';

diff --git a/test/compile/scale/type.test.ts b/test/compile/scale/type.test.ts
@@ -159,6 +159,13 @@ describe('compile/scale', () => {
           });
         });
       });
+
+      describe('time (animation)', () => {
+        it('should return band scale for nominal/ordinal data by default.', () => {
+          expect(scaleType({}, 'time', {type: 'nominal'}, 'point')).toEqual(ScaleType.BAND);
+          expect(scaleType({}, 'time', {type: 'ordinal'}, 'point')).toEqual(ScaleType.BAND);
+        });
+      });
     });
 
     describe('temporal', () => {