fix: duplicate sorting in stack (#9213)

try to close #8033, avoid duplicate field by ``` if (!s.field.includes(field)) { s.field.push(field); s.order.push(sortOrder); } ``` --------- Co-authored-by: GitHub Actions Bot <[email protected]>
vega · Dec 21, 2023 · 3e35dc2 · 3e35dc2
1 parent fa225a9
commit 3e35dc2
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 10 deletions.
diff --git a/examples/compiled/arc_radial.png b/examples/compiled/arc_radial.png
diff --git a/examples/compiled/arc_radial.vg.json b/examples/compiled/arc_radial.vg.json
@@ -34,10 +34,7 @@
           "type": "stack",
           "groupby": [],
           "field": "data",
-          "sort": {
-            "field": ["data", "data"],
-            "order": ["ascending", "ascending"]
-          },
+          "sort": {"field": ["data"], "order": ["ascending"]},
           "as": ["data_start", "data_end"],
           "offset": "zero"
         },

diff --git a/examples/compiled/layer_arc_label.png b/examples/compiled/layer_arc_label.png
diff --git a/examples/compiled/layer_arc_label.vg.json b/examples/compiled/layer_arc_label.vg.json
@@ -44,10 +44,7 @@
           "type": "stack",
           "groupby": [],
           "field": "value",
-          "sort": {
-            "field": ["category", "category"],
-            "order": ["ascending", "ascending"]
-          },
+          "sort": {"field": ["category"], "order": ["ascending"]},
           "as": ["value_start", "value_end"],
           "offset": "zero"
         },

diff --git a/src/compile/data/stack.ts b/src/compile/data/stack.ts
@@ -146,8 +146,10 @@ export class StackNode extends DataFlowNode {
       // FIXME is the default here correct for binned fields?
       sort = stackby.reduce(
         (s, field) => {
-          s.field.push(field);
-          s.order.push(sortOrder);
+          if (!s.field.includes(field)) {
+            s.field.push(field);
+            s.order.push(sortOrder);
+          }
           return s;
         },
         {field: [], order: []}