Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add visible focus state to actions menu for A11y #841

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Jan 19, 2022

Built off of #839 by @benhammondmusic.

Chrome:

Screen.Recording.2022-01-19.at.11.44.13.mov

Safari:

Screen.Recording.2022-01-19.at.11.43.56.mov
📦 Published PR as canary version: 6.20.6--canary.841.78ab2d1.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

Version

Published prerelease version: v6.20.6-next.0

Changelog

🐛 Bug Fix

⚠️ Pushed to next

🔩 Dependency Updates

Authors: 2

@domoritz
Copy link
Member Author

@benhammondmusic what do you think about this? It's almost like yours but maybe a bit simpler.

@domoritz domoritz merged commit d71f2b2 into next Feb 9, 2022
@domoritz domoritz deleted the dom/focus-ring branch February 9, 2022 22:56
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

🚀 PR was released in v6.20.6 🚀

@github-actions github-actions bot added released this feature has been released! and removed prerelease labels Feb 9, 2022
@benhammondmusic
Copy link

This is great; thank you so much addressing this. Sorry I was MIA for a bit.

@domoritz
Copy link
Member Author

Thank you for getting the ball rolling on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released this feature has been released!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants