Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add visible focus state to actions menu for A11y #839

Closed
wants to merge 31 commits into from
Closed

fix: add visible focus state to actions menu for A11y #839

Changes from 4 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
2962ab7
adds accessible focus state indicator to actions menu for keyboard users
benhammondmusic Jan 17, 2022
b031490
push build
benhammondmusic Jan 17, 2022
dfbe308
build files
benhammondmusic Jan 17, 2022
0207f70
adds visible focus state to actions menu for better keyboard user acc…
benhammondmusic Jan 17, 2022
a082495
Merge branch 'next' of https://github.com/vega/vega-embed into ben/a1…
benhammondmusic Jan 17, 2022
e0e0bc7
fix: adds visible focus indicators to actions menu
benhammondmusic Jan 17, 2022
001f0d3
fix: a11y actions menu
benhammondmusic Jan 17, 2022
03b8cf7
build w focus visible
benhammondmusic Jan 19, 2022
43bff21
undo build commits
benhammondmusic Jan 19, 2022
2bcba13
gitignore
benhammondmusic Jan 19, 2022
0ac2b1b
rm build files
benhammondmusic Jan 19, 2022
08e4422
build files for testing
benhammondmusic Jan 19, 2022
d028cc5
Merge branch 'ben/a11y-actions-menu' into next
benhammondmusic Jan 19, 2022
f3ed92c
only add focus rings to keyboard
benhammondmusic Jan 19, 2022
f0ab890
build
benhammondmusic Jan 19, 2022
3b0f612
build
benhammondmusic Jan 19, 2022
10d75b0
rebuild with outline none
benhammondmusic Jan 19, 2022
aaff308
b
benhammondmusic Jan 19, 2022
a6a9c55
b
benhammondmusic Jan 19, 2022
d2ae0e6
bb
benhammondmusic Jan 19, 2022
36346b0
build with focus
benhammondmusic Jan 19, 2022
a14a44a
rebuild
benhammondmusic Jan 19, 2022
69588d3
b
benhammondmusic Jan 19, 2022
0221ec5
b
benhammondmusic Jan 19, 2022
2ef69e6
b
benhammondmusic Jan 19, 2022
6ca341e
b
benhammondmusic Jan 19, 2022
565ef18
b
benhammondmusic Jan 19, 2022
8a9c047
b
benhammondmusic Jan 19, 2022
ea00186
b
benhammondmusic Jan 19, 2022
6dd7831
fix: focus for actions menu
benhammondmusic Jan 19, 2022
022ba9b
remove highlight when menu item in focus
benhammondmusic Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vega-embed.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
border-radius: 999px;
opacity: 0.2;
transition: opacity 0.4s ease-in;
outline: none;
cursor: pointer;
line-height: 0px; // For Safari

Expand All @@ -48,7 +47,7 @@
}

&:hover summary,
&:focus summary {
&:focus-within summary {
opacity: 1 !important;
transition: opacity 0.2s ease;
}
Expand Down Expand Up @@ -80,7 +79,8 @@
color: #434a56;
text-decoration: none;

&:hover {
&:hover,
&:focus {
background-color: #f7f7f9;
color: black;
}
Expand Down