-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass locale info through to vl-convert, default to display embed options when not set #3274
Conversation
Not sure if this is something to add to this PR, but still want to mention that a while ago I wished there was |
Yeah, it seems like |
These comments from @domoritz around here: vega/vega-embed#170 (comment) might give more insight:
And
|
I suggest to document this in Customizing Renderers chapter, maybe in a dedicated subchapter? I usually add documentation via different PR, but to me it makes no difference. What should we add? I guess how to set locale for visualization via |
@mattijn @MarcoBaroncini I added a new documentation section under "Customizing Visualizations". See if the description here makes sense. Note that I used a static SVG for the localization example chart output because I also added a changelog entry. I think this PR is ready to go now! |
Thanks @jonmmease, I've added a note how to set the default and changed javascript style variable names into the equivalent python style. Once the tests pass, we can merge this. |
Thanks @mattijn! |
This PR makes three changes related to locale handling:
it-IT
) rather than only by setting the full locale dictionary.alt.renderers.set_embed_options
(if any). This way you can callalt.renderers.set_embed_options
once and all of the charts will be displayed and saved using the provided locale configuration.Still needs documentation, but I haven't decided whether to tackle that in this PR or not. If folks have ideas for where best to document this functionality let me know!
cc @MarcoBaroncini