Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI #167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CI #167

wants to merge 1 commit into from

Conversation

varnerac
Copy link

Adds continuous integration via GitHub Actions to build firmware for different versions. The build_all results are uploaded as artifacts. Right now I have it run on every push. Based on the release strategy, you could change it to PRs, etc. I am hoping this makes it easier for folks to test the 5.x branch without having to install an ARM build chain locally.

@varnerac
Copy link
Author

As a side note, I can also have it automatic upload release binaries to the GitHub release page after you tag a release. That way you could have 5.0.0-rc1, 5.0.0-rc2, etc.

@Teslafly
Copy link
Contributor

This should be re-targeted to the dev_fw_5_03 branch.

@vedderb, is there any reason you don't want CI on vesc-fw/vesc-tool? There are open pull requests on both to add this.

Also, as there have been some issues with newer versions on the arm toolchain, this doesn't look like it currently locks that down. See #210.

I would love automatic release candidates though. Especially for vesc tool.

@kubark42
Copy link
Contributor

kubark42 commented Oct 13, 2021

CI would be great! It seems like a low-risk, high-reward upgrade. The results can always be ignored if the build server is broken, so there's not a strong downside which I see.

The upside is that PRs become more robust, and the chances of accidentally merging in broken code goes down, esp. if this is tied to unit tests. This is very valuable for when people would like to contribute small fixes, but don't have the hardware to test that their fixes do no harm.

@rusefillc
Copy link

@vedderb what are your thoughts on this PR?

This was referenced Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants