Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Trying to create new event on PHP 8 sites throws an error:
After
Event creation page works fine:
Technical notes
This PR is built in top of the other PR here: #53 that regenerates the civix file so it can work with PHP 8 sites, but this is not the whole story, where when trying to access the event creation page it throws an error as can be seen on the "before" section, and the following error will show in logs:
which happen because some parts of this extension code tries to access this method
CRM_Gotowebinar_Utils ::isCiviCRMVersion47
statically , but the method itself is not a static method, which is no longer allowed in PHP 8.In this PR I changed this method along with the rest of the methods inside
CRM_Gotowebinar_Utils
class to be static, given they are all called statically within this extension code.I also removed a call for a class that does not exist in CiviCRM codebase
CRM_Finance_BAO_Import_ValidateException
and replaced it withCRM_Core_Exception
.